Dimming improvements #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 10, 2019 17:52
There are additional stages to dimming and it never goes completely off so that there is always a reference to the last color. This could be improved futher by making the system generalized so it is easy to change in the code.
coderforlife
commented
Jan 10, 2019
| @@ -111,7 +113,7 @@ int rPin = D3; | |||
| unsigned char myId = 0; | |||
|
|
|||
| int currentEvent = tEVENT_NONE; | |||
| int eventTime = Time.now(); | |||
| int eventTime = 0; | |||
There was a problem hiding this comment.
Note that seeding this with Time.now() means that it is impossible to grab the current color it should be and it just stays dark until a light is touched somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the color-spectrum improvements along with several minor improvements to the quality and efficiency of the code. Additionally, it adds in a new set of dimming times and never goes completely dark so that the last color can always be seen. The light is quite dim at this point and shouldn't interfere too much.