-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
3642256
commit 5b86d32
Showing
1 changed file
with
7 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1,26 @@ | ||
| ## Resubmission | ||
|
|
||
| This is a resubmission to fix 'Additional issues' on CRAN checks as requested. | ||
|
|
||
| We were unable to reproduce the exact valgrind/gcc-ASAN/clang-ASAN issue | ||
| identified in our re-submission (0.2.2), but have removed tangential | ||
| functionality that used 'rstan', which appears to have caused the errors on | ||
| the last CRAN checks. | ||
|
|
||
| We have tested the new package with valgrind on two systems and | ||
| with clang-ASAN/clang-UBSAN on the latest Fedora attempting to match the CRAN | ||
| setup and our checks pass. | ||
|
|
||
| Compared to the previously published version 0.2.1: | ||
|
|
||
| * We fixed a valgrind-detected issue with a vector length. | ||
| * We removed 2 Latin-1 strings in package data. | ||
| * We added 'future' and 'lme4' to Suggests to avoid 'Rd cross-references' | ||
| 'Undeclared packages' NOTE. | ||
| * We removed selected vignettes and reduced the size of an included dataset. | ||
| The majority of the size is due to compiled code. | ||
|
|
||
| ## R CMD check results | ||
|
|
||
| 0 errors | 0 warnings | 2 notes | ||
| 0 errors | 0 warnings | 0 notes | ||
|
|
||
| Suggests or Enhances not in mainstream repositories: | ||
| INLA | ||
| Availability using Additional_repositories specification: | ||
| INLA yes https://inla.r-inla-download.org/R/stable | ||
| ... | ||
| Package unavailable to check Rd xrefs: 'INLA' | ||
|
|
||
| * This is correct and intended; INLA is not on CRAN. | ||
|
|
||
| checking installed package size ... NOTE | ||
| installed size is 5.5Mb | ||
| installed size is 6.0Mb | ||
| sub-directories of 1Mb or more: | ||
| libs 3.7Mb | ||
| libs 4.1Mb | ||
|
|
||
| * This is due to compiled code; we cannot reduce the size further. | ||
|
|
||
| ## Test environments | ||
|
|
||
| * local macOS install, R 4.2.2 | ||
| * Windows (on github-actions), R 4.2.2 | ||
| * Ubuntu 20.04.4 (on github-actions), R-devel | ||
| * local macOS install, R 4.3.1 | ||
| * Windows (on github-actions), R 4.3.1 | ||
| * Ubuntu 22.04.3 (on github-actions), R-devel | ||
| * Windows (winbuilder), R devel | ||
| * Windows (winbuilder), R release | ||
|
|
||
| With sanitizer checks: | ||
|
|
||
| * Fedora release 38 (on docker), R-devel with clang ASAN, clang-UBSAN | ||
| * Ubuntu 20.04.4 (on github-actions), R-devel with valgrind | ||
| * Ubuntu 20.04.4 (on docker), R-devel with valgrind level 2 instrumentation | ||
|
|