Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for factor random intercept columns in newdata and add tests, fixes #278 #280

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Check for factor random intercept columns in newdata and add tests, fixes #278 #280

merged 2 commits into from
Nov 29, 2023

Conversation

sebpardo
Copy link
Contributor

I took the long way around but in the end it seems it was a pretty straightforward fix 😸

@seananderson
Copy link
Member

Thanks! In the unit test, can you set spatial = "off" and spatiotemporal = "off" (or don't specify time) and skip the mesh creation just for speed? The unit tests add up.

@seananderson seananderson merged commit cfb19c4 into pbs-assess:main Nov 29, 2023
4 of 6 checks passed
@sebpardo sebpardo deleted the re-check branch November 29, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebpardo @seananderson