Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prettier extension to the workspace and set format on Save=true #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahmoudmoravej
Copy link
Contributor

Let's recommend installing prettier extension by default.
Also allowing formating on save makes the life less dependent on "yarn format" command

@mahmoudmoravej
Copy link
Contributor Author

@pbteja1998 if you agree 😄

@jameswinegar
Copy link

IDE-specific settings should typically be in .gitignore, and validation should be run via a GitHub action.

@mahmoudmoravej
Copy link
Contributor Author

mahmoudmoravej commented Feb 22, 2024

IDE-specific settings should typically be in .gitignore, and validation should be run via a GitHub action.

@jameswinegar Any specific reason behind it? There is lots of value for having it while it doesn't affect other IDEs. Remix also use this pattern: https://github.com/remix-run/remix/blob/main/.vscode/extensions.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants