Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liking memories offline #146

Merged
merged 5 commits into from
Jul 26, 2017
Merged

Liking memories offline #146

merged 5 commits into from
Jul 26, 2017

Conversation

pbywater
Copy link
Owner

Extends on service worker pull request

  • Refactors some functions for deleting logic so they also work for liking
  • Adds logic and helpers for liking offline and sending updated likes to the DB when back online

relates to #138 #145

@pbywater pbywater requested review from joeylouise and a user July 21, 2017 10:40
@des-des des-des assigned pbywater and unassigned des-des Jul 21, 2017
@des-des
Copy link
Collaborator

des-des commented Jul 21, 2017

@pbywater re-assign when previous is in

@pbywater pbywater assigned des-des and unassigned pbywater Jul 26, 2017
@des-des des-des merged commit ff53207 into master Jul 26, 2017
@des-des des-des deleted the offline-likes branch July 26, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@des-des des-des des-des approved these changes

@joeylouise joeylouise Awaiting requested review from joeylouise

Assignees

@des-des des-des

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbywater @des-des