Adding text memories offline #168
Conversation
| const heading = splitData[0].split('=')[1]; | ||
| const text = splitData[1].split('=')[1]; | ||
| const tag = splitData[2].split('=')[1]; | ||
| const id = getRandomInt(10000, 999999); |
There was a problem hiding this comment.
Not convinced by this approach to id generation
There was a problem hiding this comment.
- Use uuid or something similar for client side id generation.
- Either generate ids on the server, or on the client, do not do some mixture of the 2.
If 2 is too difficult, you could try and generate some kind of temporary id on the client, then replace it with the one generated by the db..
There was a problem hiding this comment.
This is just temporary - a real id is created in the normal way once the user goes back online
| } else { | ||
| const data = $('#add-text-form').serialize(); | ||
| const splitData = data.split('&'); | ||
| const heading = splitData[0].split('=')[1]; |
There was a problem hiding this comment.
Dont do this, just get the data from each field separately.
There was a problem hiding this comment.
ie heading = $('sel').value
There was a problem hiding this comment.
Tried this but I'm getting undefined :(
src/client/helpers/helpers.js
Outdated
| @@ -287,6 +296,21 @@ function deletePendingMemories(cb) { | |||
| cb(); | |||
| }) | |||
| } | |||
| if(localStorage.getItem('textToAdd') !== null) { | |||
| const newTextMemories = JSON.parse(localStorage.getItem('textToAdd')); | |||
| @@ -287,6 +296,21 @@ function deletePendingMemories(cb) { | |||
| cb(); | |||
There was a problem hiding this comment.
?? How many times does this callback get called
There was a problem hiding this comment.
Every time something is deleted I think! Haha - I think we discussed before and said it wasn't ideal but would be ok due to time constraints?
src/client/helpers/helpers.js
Outdated
| data: {memory_text: text, heading, tag}, | ||
| success: () => clearPendingActions('textToAdd', index), | ||
| }); | ||
| cb(); |
There was a problem hiding this comment.
How many times does this callback get called / this does not make any sense / this is broken
There was a problem hiding this comment.
😭 - it's rerendering after each update so if there are several updates, there are several transitions. Is there a better way to do it?
src/client/helpers/helpers.js
Outdated
| offlineData.push(toAdd); | ||
| const offlineDataAfterAdding = JSON.stringify(offlineData); | ||
| localStorage.setItem('data', offlineDataAfterAdding); | ||
| return offlineData; |
Relates to #163