Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
npasserini
reviewed
Dec 6, 2024
| } | ||
|
|
||
| method modificarIntensidadElevada(nuevaIntensidad) { | ||
| Emocion.cambiarIntensidadElevada(nuevaIntensidad) |
There was a problem hiding this comment.
No se le pueden mandar mensajes a las clases.
| Emocion.cambiarIntensidadElevada(nuevaIntensidad) | ||
| } | ||
|
|
||
| method vivirEventoEnGrupo(grupo, evento) { |
There was a problem hiding this comment.
Este código no corresponde a las personas.
| class Emocion { | ||
| var property intensidad | ||
| var property intensidadElevada = 50 |
There was a problem hiding this comment.
Debería ser única para todas las emociones.
| return intensidad >= intensidadElevada | ||
| } | ||
| method cambiarIntensidadElevada(nuevaIntensidad) { |
There was a problem hiding this comment.
Debería ser global a todas las emociones.
| //implemento la funcion liberacionAux para no repetir return super() && condicionDeEmocion cada vez que tengo que hacer un overrite en liberarEmocion | ||
| object liberacionAux { | ||
| method puedeLiberarse(emocion, condicionAdicional) { |
There was a problem hiding this comment.
Bien por la intención de no repetir, aunque hay otros mecanismos mejores.
| palabrotas.remove(palabrotas.head()) | ||
| } | ||
| }} |
There was a problem hiding this comment.
El código mal indentado dificulta la lectura.
| method liberarse(evento) { | ||
| causa = evento.descripcion() | ||
| intensidad -= evento.impacto() |
|
|
||
| method liberarse(evento) { | ||
| intensidad -= evento.impacto() |
| En este caso, todas las emociones heredan de la clase Emocion, lo que permite compartir y reutilizar el comportamiento común, como la gestión de la intensidad y los eventos vividos. | ||
|
|
||
| Polimorfismo: Permite que objetos de diferentes clases sean tratados como objetos de una clase común. En este caso, cada emoción tiene su propia implementación del método liberarse, pero todas pueden ser manejadas de la misma manera a través de la clase Emocion. |
There was a problem hiding this comment.
No es necesario hablar de clases para tener polimorfismo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @franco-lapalma