Redefine the call of share and reclaim #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yushan-Wang
approved these changes
Mar 31, 2025
JAuriac
reviewed
Apr 2, 2025
Comment on lines
+476
to
+481
| ```C | ||
| PDI_multi_expose("finalization", | ||
| "ii", &ii, PDI_OUT, | ||
| "main_field", cur, PDI_OUT, | ||
| NULL); | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ```C | |
| PDI_multi_expose("finalization", | |
| "ii", &ii, PDI_OUT, | |
| "main_field", cur, PDI_OUT, | |
| NULL); | |
| ``` | |
| ```C | |
| PDI_multi_expose("finalization", | |
| "ii", &ii, PDI_OUT, | |
| "main_field", cur, PDI_OUT, | |
| NULL); |
Comment on lines
+483
to
+485
| \attention | ||
| In a `::PDI_multi_expose` if you have a data1 that depend on the data2. | ||
| You need to pass the data2 before the data1 |
There was a problem hiding this comment.
Suggested change
| \attention | |
| In a `::PDI_multi_expose` if you have a data1 that depend on the data2. | |
| You need to pass the data2 before the data1 | |
| \attention | |
| In a `::PDI_multi_expose` if you have a data1 that depends on the data2. | |
| You need to expose the data2 before the data1. |
Comment on lines
+488
to
+493
| ```C | ||
| PDI_multi_expose("save_vector_V", | ||
| "size_of_vector", &N, PDI_OUT, | ||
| "vector_V", V, PDI_OUT, | ||
| NULL); | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ```C | |
| PDI_multi_expose("save_vector_V", | |
| "size_of_vector", &N, PDI_OUT, | |
| "vector_V", V, PDI_OUT, | |
| NULL); | |
| ``` | |
| ```C | |
| PDI_multi_expose("save_vector_V", | |
| "size_of_vector", &N, PDI_OUT, | |
| "vector_V", V, PDI_OUT, | |
| NULL); |
README.md
Outdated
Comment on lines
459
to
461
| In the first line, `cur` correspond to the value of `main_field` at iteration | ||
| `ii=4`. As `ii` is a metadata, the value is stored by pdi. | ||
| Hence, in this first line the value of `ii` is equal to 3. |
Comment on lines
+439
to
+441
| The order of share are importants when we used a metadata. We explain that | ||
| without `::PDI_multi_expose` to be more clear. | ||
| In `::PDI_share`, the event "on_data" on the shared data are performed. |
There was a problem hiding this comment.
Suggested change
| The order of share are importants when we used a metadata. We explain that | |
| without `::PDI_multi_expose` to be more clear. | |
| In `::PDI_share`, the event "on_data" on the shared data are performed. | |
| The order of `share` is important when using a metadata field. As seen below, | |
| the exercise 6 decompose a `multi_expose` call to demonstrate this. | |
| Furthermore, when using `::PDI_share`, an event "on_data" | |
| is automatically performed. |
benoitmartin88
requested changes
Apr 2, 2025
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.