-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added usdt, usdc.e and zk tokens for zksync mainnet #141
feat: added usdt, usdc.e and zk tokens for zksync mainnet #141
Conversation
WalkthroughThe recent updates involve enhancements to the token datasets by updating logo URIs for existing tokens and integrating new token entries. Specifically, the token details now include Tether USD, Bridged USDC, and ZKsync, each enriched with their respective attributes. These changes improve the dataset without altering its overall structure or functionality. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/data/tokenDetails.json (4 hunks)
- src/data/tokenDetailsManual.json (1 hunks)
Additional comments not posted (4)
src/data/tokenDetailsManual.json (1)
77-102
: Review the new token entries forchainId
324.
Tether USD (USDT):
- Address: The address
0x493257fD37EDB34451f62EDf8D2a0C418852bA4C
is correctly formatted as an Ethereum address.- Decimals: The value
6
is standard for USDT.- Logo URI: The URI points to a valid image source.
Bridged USDC (USDC.e):
- Address: The address
0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4
is correctly formatted.- Decimals: The value
6
is consistent with USDC tokens.- Logo URI: The URI is a valid image link.
ZKsync (ZK):
- Address: The address
0x5A7d6b2F92C77FAD6CCaBd7EE0624E64907Eaf3E
is correctly formatted.- Decimals: The value
18
is typical for tokens like ZK.- Logo URI: The URI points to a valid image source.
The entries align with the PR summary and AI-generated summary. Ensure that these tokens are correctly integrated into any systems relying on this data.
src/data/tokenDetails.json (3)
2228-2233
: Token entry for Tether USD (USDT) is correct.The details for the Tether USD (USDT) token, including the address, name, symbol, decimals, and logoURI, match the PR summary.
2235-2240
: Token entry for Bridged USDC (USDC.e) is correct.The details for the Bridged USDC (USDC.e) token, including the address, name, symbol, decimals, and logoURI, match the PR summary.
2242-2246
: Token entry for ZKsync (ZK) is correct.The details for the ZKsync (ZK) token, including the address, name, symbol, decimals, and logoURI, match the PR summary.
WHAT
Added
USDT
,USDC.e
andZK
tokens on chainId=324 (ZKsync Mainnet)WHY
These tokens are mostly used tokens on Clave Application, which utilizes ZKsync Mainnet
HOW
Added the following config to the manual token list and run
python fillTokenDetails.py
:Summary by CodeRabbit
New Features
Enhancements