Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added usdt, usdc.e and zk tokens for zksync mainnet #141

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

asgarovf
Copy link
Contributor

@asgarovf asgarovf commented Aug 11, 2024

WHAT

Added USDT, USDC.e and ZK tokens on chainId=324 (ZKsync Mainnet)

WHY

These tokens are mostly used tokens on Clave Application, which utilizes ZKsync Mainnet

HOW

Added the following config to the manual token list and run python fillTokenDetails.py:

{
    "chainId": "324",
    "tokens": [
	{
		"address": "0x493257fD37EDB34451f62EDf8D2a0C418852bA4C",
		"name": "Tether USD",
		"symbol": "USDT",
		"decimals": 6,
		"logoURI": "https://assets.coingecko.com/coins/images/325/thumb/Tether.png?1700119918"
	},
	{
		"address": "0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4",
		"name": "Bridged USDC",
		"symbol": "USDC.e",
		"decimals": 6,
		"logoURI": "https://assets.coingecko.com/coins/images/35262/thumb/USDC_Icon.png?1700119918"
	},
	{
		"address": "0x5A7d6b2F92C77FAD6CCaBd7EE0624E64907Eaf3E",
		"name": "ZKsync",
		"symbol": "ZK",
		"decimals": 18,
		"logoURI": "https://assets.coingecko.com/coins/images/38043/thumb/ZKTokenBlack.png?1700119918"
	}
    ]
}

Summary by CodeRabbit

  • New Features

    • Updated logo URIs for existing tokens including Wrapped Ether (WETH), USD Coin (USDC), and Dai Stablecoin (DAI).
    • Introduced three new tokens: Tether USD (USDT), Bridged USDC (USDC.e), and ZKsync (ZK) with complete details including address, symbol, decimals, and logo URI.
  • Enhancements

    • Expanded dataset for token details, improving token identification and display capabilities.

Copy link

coderabbitai bot commented Aug 11, 2024

Walkthrough

The recent updates involve enhancements to the token datasets by updating logo URIs for existing tokens and integrating new token entries. Specifically, the token details now include Tether USD, Bridged USDC, and ZKsync, each enriched with their respective attributes. These changes improve the dataset without altering its overall structure or functionality.

Changes

Files Change Summary
src/data/tokenDetails.json Updated logo URIs for existing tokens and added new entries for USDT, USDC.e, and ZK.
src/data/tokenDetailsManual.json Added a new entry for chainId "324" with tokens USDT, USDC.e, and ZK, enhancing token data.

Poem

🐰 In the meadow where tokens play,
New friends join us on this day!
With logos bright and names so clear,
Tether and ZK bring us cheer!
Let’s dance and hop, oh what delight,
In the world of crypto, everything feels right! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 88ef4cd and 12c423d.

Files selected for processing (2)
  • src/data/tokenDetails.json (4 hunks)
  • src/data/tokenDetailsManual.json (1 hunks)
Additional comments not posted (4)
src/data/tokenDetailsManual.json (1)

77-102: Review the new token entries for chainId 324.

  1. Tether USD (USDT):

    • Address: The address 0x493257fD37EDB34451f62EDf8D2a0C418852bA4C is correctly formatted as an Ethereum address.
    • Decimals: The value 6 is standard for USDT.
    • Logo URI: The URI points to a valid image source.
  2. Bridged USDC (USDC.e):

    • Address: The address 0x3355df6D4c9C3035724Fd0e3914dE96A5a83aaf4 is correctly formatted.
    • Decimals: The value 6 is consistent with USDC tokens.
    • Logo URI: The URI is a valid image link.
  3. ZKsync (ZK):

    • Address: The address 0x5A7d6b2F92C77FAD6CCaBd7EE0624E64907Eaf3E is correctly formatted.
    • Decimals: The value 18 is typical for tokens like ZK.
    • Logo URI: The URI points to a valid image source.

The entries align with the PR summary and AI-generated summary. Ensure that these tokens are correctly integrated into any systems relying on this data.

src/data/tokenDetails.json (3)

2228-2233: Token entry for Tether USD (USDT) is correct.

The details for the Tether USD (USDT) token, including the address, name, symbol, decimals, and logoURI, match the PR summary.


2235-2240: Token entry for Bridged USDC (USDC.e) is correct.

The details for the Bridged USDC (USDC.e) token, including the address, name, symbol, decimals, and logoURI, match the PR summary.


2242-2246: Token entry for ZKsync (ZK) is correct.

The details for the ZKsync (ZK) token, including the address, name, symbol, decimals, and logoURI, match the PR summary.

@borcherd borcherd merged commit 80ff96a into peanutprotocol:main Aug 12, 2024
1 check failed
@coderabbitai coderabbitai bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants