bugfix: return pear error object on factory with scram authentication… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnazg
requested changes
Mar 10, 2024
| @@ -68,7 +68,18 @@ class Auth_SASL_SCRAM extends Auth_SASL_Common | |||
| * format of core PHP hash function. | |||
| * @access public | |||
| */ | |||
| function __construct($hash) | |||
| function __construct() | |||
There was a problem hiding this comment.
You are intentionally breaking the constructor signature for v2.0?
There was a problem hiding this comment.
Ah, i'm sorry @ashnazg. You're totally right. Sorry. I missed your comment. I will fix that soon. Thanks for your patience. :-)
There was a problem hiding this comment.
ToDo for @schengawegga: Leave parameter on constructor and call factory if parameter is set.
|
@schengawegga: Have you seen the @ashnazg comment? |
|
@schengawegga: Have you progressed on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… method