Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning with finch 0.17 #168

Closed
wants to merge 1 commit into from
Closed

Fix deprecation warning with finch 0.17 #168

wants to merge 1 commit into from

Conversation

dvic
Copy link

@dvic dvic commented Jan 11, 2024 •
edited
Loading

Finch 0.17 deprecated the protocol pool option: sneako/finch@334af8e

This PR checks the Finch version at runtime and passes the appropriate pool option.

@dvic
Copy link
Author

dvic commented Jan 11, 2024 •
edited
Loading

Ooops, totally missed #167 and the suggestion to drop the pools option altogether. Feel free to close this if that is preferred to this PR.

@wojtekmach
Copy link
Collaborator

Thanks for the PR, closing in favour of #167!

@wojtekmach wojtekmach closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvic @wojtekmach