Advanced Title support and proper handling of children #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
advanced-title
branch
from
b211436
to
95eae77
Compare
dignifiedquire
force-pushed
the
advanced-title
branch
from
c813a75
to
98325dd
Compare
|
+1 for this It works either way, but i get a bit annoyed at the warnings during development. |
|
+1, especially the props.children issue. |
|
+1, also needed for tabs translated/localised/internationalised with react-intl component |
|
+1 this one is good! Why is the merge not accepted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
thanks for the nice component, here are some fixed that I need to make it working with everything I need.
titleto be an element. This gives the ability to pass in something liketitle={<span><b>Advanced</b> <i>Title</i></span>.this.props.childrenare handled usingReact.Childrento avoid any issues with different types of children. (I was running into issues using it with formsy-react. This also removes the need to explicitly handle single child cases, as well as the need to filter out falsy children.