Replace CSV with JSON as file format for ISO Currency definitions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mordil
added
enhancement
santicarmo31
approved these changes
Jan 6, 2025
Mordil
force-pushed
the
remove-old-impl
branch
from
1ce803c to
5286492
Compare
Motivation: We're pulling in a dependency for CSV parsing as part of the build tool, forcing a transitive dependency on all users. We simply need a way of storing the original definitions from the ISO Standard committee and parsing them as part of the build process, and JSON + `Codable` solves that for us easily. Modifications: - Change: Code to be a bit more legible on what's going on with the codegen - Change: Data parsing from CSV to JSON using `Decodable` - Rename: Files to be a bit more easily understandable of what's in each file - Remove: **SwiftCSV** dependency Result: The build plugin is a bit easier to maintain, and there is now no dependencies in the project.
|
Latest push was a rebase off the target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We're pulling in a dependency for CSV parsing as part of the build tool, forcing a transitive dependency on all users.
We simply need a way of storing the original definitions from the ISO Standard committee and parsing them as part of the build process, and JSON +
Codablesolves that for us easily.Modifications:
DecodableResult:
The build plugin is a bit easier to maintain, and there is now no dependencies in the project.