Skip to content

Commit

Permalink
moved expansion arrow for better UX.
Browse files Browse the repository at this point in the history
removed extra scrollbar from scrollview div.
  • Loading branch information
Korey Sedaghatian committed Feb 27, 2024
1 parent 40f1a04 commit 5047fb6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 17 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ff3-ofx",
"version": "0.4.1",
"version": "0.4.2",
"homepage": "./",
"private": true,
"licenses": [
Expand Down
1 change: 0 additions & 1 deletion src/App.css
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ input {
margin: 0 auto;
width: 100%;
min-width: 900px;
overflow-y: scroll;
}

.matching-txns th,
Expand Down
18 changes: 3 additions & 15 deletions src/components/OfxTransactionsRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ const OfxTransactionsRow = (props: OfxTransactionsTableProps) => {
jsx = <Chip label="exact matched" color="primary" />;
break;
case 'match-value':
jsx = <Chip label="amount matched" color="secondary" />;
jsx = <Chip label="amount matched" color="secondary"
deleteIcon={open ? <KeyboardArrowUpIcon /> : <KeyboardArrowDownIcon />}
onDelete={() => setOpen(!open)}/>;
break;
case 'success':
jsx = <Chip label="added" color="success" />;
Expand All @@ -39,21 +41,7 @@ const OfxTransactionsRow = (props: OfxTransactionsTableProps) => {
<Fragment key={`ofxTxn_${props.index}_root`}>
<TableRow>
<TableCell>
<>
{
['failure', 'match-value'].includes(props.transaction.importStatus?.status || '') && (
<IconButton
aria-label="expand row"
size="small"
onClick={() => setOpen(!open)}
sx={{float: 'right', '&:hover': {backgroundColor: 'rgb(156, 39, 176)', color: '#fff'} }}
>
{open ? <KeyboardArrowUpIcon /> : <KeyboardArrowDownIcon />}
</IconButton>
)
}
{props.transaction.description}
</>
</TableCell>
<TableCell align="center">
{props.transaction.datePosted.format('DD-MMM-YYYY')}
Expand Down

0 comments on commit 5047fb6

Please sign in to comment.