Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping "sys_ptrace" capability. #17

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

nu11daemon
Copy link
Contributor

@nu11daemon nu11daemon commented May 16, 2024

proot is a program known for its usage in creating unprivileged chroots.
This program essentially gives the user the capability create a chroot into another system without any permissions, effectively turning the container into a "server" - which is not an intended use for a container.

However, this program relies on a unprivileged system call in Linux systems known as ptrace, and by disabling it, scripts such as PteroVM or any of its derivatives will be rendered useless.

Before merging, please conduct some tests as this might cause potential break in some eggs (maybe?)

Ptrace is known for it's use in software such as proot, mostly used with purposes other than it's intended use.
@iamkubi
Copy link
Contributor

iamkubi commented May 20, 2024

Thanks. I think this change makes sense but will need to test it out. I bet there is some egg like a VSCode server or something that uses this legitimately. I can add a config option to add the capability back if that's the case, but I'll need to do some testing.

@parkervcp
Copy link
Contributor

I can't see any reason to keep it, unless some service needs it to track a process. The only thing I can think of is possibly the Don't Starve Together egg.

Copy link
Contributor

@parkervcp parkervcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a change that will break things for us but we can always revert if there are widespread problems.

@parkervcp parkervcp merged commit e5e1de5 into pelican-dev:main Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants