Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize differences with upstream plugin template #17

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Minimize differences with upstream plugin template #17

merged 3 commits into from
Nov 3, 2024

Conversation

justinmayer
Copy link
Contributor

I made a few follow-up tweaks to the fabulous work by @offbyone in #16, mainly designed to minimize the differences between this plugin and the upstream plugin template.

After this is merged, developers should be able to run invoke update --check to see if there are upstream template changes, and if so, run invoke update to apply them 😁

@justinmayer justinmayer requested a review from offbyone November 3, 2024 14:59
[project]
name = "pelican-webassets"
version = "2.1.0"
description = "Pelican plugin to manage web assets such as CSS and JS files"
authors = [
{ name ="Pelican Dev Team <[email protected]>" },
{name = "Pelican Dev Team", email = "[email protected]"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurs to me, I should probably add myself to this list, or at least have the option of seeing emails to there :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! I just tried to add you, but my domain name registrar only allows forwarding to a single email address, so at the moment that addition is more complicated than I would like. At some point I may add the getpelican.com domain to my self-hosted mail server, which would obviously provide a lot more flexibility. In the interim, let me assure you that you're not missing much. I think that address might receive a single message in a calendar year — if that 😉

@offbyone offbyone merged commit 91c74d0 into main Nov 3, 2024
14 checks passed
@offbyone offbyone deleted the cruft branch November 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants