Fix Closures in MaxValue and MinValue #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered issues similar to #72 when trying to inject a service into a closure passed to the
minValue
method.I compared the
MoneyInput::minValue
method with its counterpart in TextInput::getMinValue and noticed that$this->evaluate($value)
was being called too early in theMoneyInput
implementation.This was what caused the
Typed property Filament\Forms\Components\Component::$container must not be accessed before initialization
Error.As the closure is evaluated in TextInput::getMinValue anyway, there seems to be no need for
minValue
ormaxValue
to evaluate $value at all.So i aligned the way
minValue
andmaxValue
works to the wayTextInput
does it.After these changes: