-
Notifications
You must be signed in to change notification settings - Fork 66
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use Float instead of Double to reduce memory footprint (#101)
- Loading branch information
Showing
9 changed files
with
358 additions
and
357 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
7633ea9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the accuracy reports? It would be interesting to see what effect this had on them.
Maybe it would be possible to increase accuracy a bit again by only storing the frequencies as
Float
but still performing the calculations, such as summing frequencies, withDouble
. What do you think?7633ea9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no considerable accuracy difference. I've already checked that. So there is actually no need to use
Double
.