Regression - #1799: Fix pen dabs being added to each other #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrStevns
force-pushed
the
#1799-pen-dab-alpha-fix
branch
from
a6a17d1 to
4dbd2bc
Compare
MrStevns
changed the title
J5lx
requested changes
Dec 3, 2023
MrStevns
force-pushed
the
#1799-pen-dab-alpha-fix
branch
from
4dbd2bc to
8baa511
Compare
|
Hmm.. you're right, that was not correct. Even though I tested and compared against the stable version, I failed to see the difference. This time i've made sure to apply the exact same steps. |
J5lx
requested changes
Dec 3, 2023
|
Ah you're right, that seems to be the case with master as well though but it's likely my fault too and related, so I'll look into it. If only i had written some tests to avoid these cases 😔 There's still room for improvements regarding separation of concern 🙃 |
|
No, I’m seeing that eraser issue only with this PR. Whatever you’re seeing on master must be a separate issue from what I described above. |
Actually the first check in canvas painter would always return true because the blitRect and mTilledBuffer rect are in different coordinate spaces.
MrStevns
force-pushed
the
#1799-pen-dab-alpha-fix
branch
from
b4e4faa to
061e085
Compare
|
I've had some time to think and experimented a bit.. try again with the latest changes. Also thanks for reviewing and being meticulous 😄 |
J5lx
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1799 which was reported on Discord https://discord.com/channels/342369662710972417/375357444307812352/1180835637566390344