Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallax movement for backgrounds, and many other things... #1811

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
094d2f9
Makes it possible to interpolate keyframes, to optain parallaxe effect
davidlamhauge Aug 1, 2023
bdc478a
Clean up and refactoring logic.
davidlamhauge Aug 1, 2023
1cd3dd7
Fixed problem when keyframe was copied from TEMP dir.
davidlamhauge Aug 2, 2023
cb2bf37
Works as expected. Timeline not updating until keypress. Hmmm
davidlamhauge Aug 4, 2023
c864a83
Refactoring. Update timeline still does not work.
davidlamhauge Feb 14, 2024
1894169
Merge branch 'master' into parallaxe_movement
davidlamhauge Feb 14, 2024
399aa9c
Still trying to make update-timeline work...
davidlamhauge Feb 20, 2024
865ced5
Finally figured out why timeline was not updated, with help from MrSt…
davidlamhauge Feb 27, 2024
8564739
Removed two unnecessary emits
davidlamhauge Feb 27, 2024
a54cfc2
Makes it possible to interpolate keyframes, to optain parallaxe effect
davidlamhauge Aug 1, 2023
c19fa83
Clean up and refactoring logic.
davidlamhauge Aug 1, 2023
6e40bbd
Fixed problem when keyframe was copied from TEMP dir.
davidlamhauge Aug 2, 2023
bf45b77
Works as expected. Timeline not updating until keypress. Hmmm
davidlamhauge Aug 4, 2023
67e3436
Refactoring. Update timeline still does not work.
davidlamhauge Feb 14, 2024
8a724f9
Still trying to make update-timeline work...
davidlamhauge Feb 20, 2024
4974a97
Finally figured out why timeline was not updated, with help from MrSt…
davidlamhauge Feb 27, 2024
1060cac
Removed two unnecessary emits
davidlamhauge Feb 27, 2024
e13884e
Merge branch 'parallaxe_movement' of https://github.com/davidlamhauge…
davidlamhauge Nov 20, 2024
4236dfa
Merge branch 'master' into parallaxe_movement
davidlamhauge Nov 20, 2024
f4b26fe
Merge branch 'master' into parallaxe_movement
davidlamhauge Nov 20, 2024
1948303
fixed ui error
davidlamhauge Nov 21, 2024
80683cf
Merge branch 'master' into parallaxe_movement
davidlamhauge Jan 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactoring. Update timeline still does not work.
  • Loading branch information
davidlamhauge committed Feb 14, 2024
commit c864a83accb8e34dfaa79f82185d8107abb17812
3 changes: 2 additions & 1 deletion app/src/actioncommands.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,6 @@ void ActionCommands::interpolateKeyframes()
keyframe = layer->getKeyFrameAt(i - 1);
KeyFrame* dupKey = keyframe->clone();
layer->addKeyFrame(i, dupKey);
mEditor->scrubTo(i);
BitmapImage* image = layer->getBitmapImageAtFrame(i);
percent = counter / interpolations;
QRect transformer = QRect(upperLine.pointAt(percent).toPoint(),
Expand All @@ -664,7 +663,9 @@ void ActionCommands::interpolateKeyframes()
image->modification();
counter++;
layer->markFrameAsDirty(i);
mEditor->scrubTo(i);
}
emit mEditor->updateTimeLine();
emit mEditor->framesModified();
mEditor->scrubTo(last);
}
Expand Down