Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delayed vector transformation rendering #1818

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

MrStevns
Copy link
Member

@MrStevns MrStevns commented Apr 10, 2024

This PR fixes a small cosmetic bug I stumbled upon while working on the new undo/redo feature.

How to reproduce:

  1. Draw a vector stroke
  2. Select it using the Select tool
  3. Move or transform using the Move tool
  4. undo/redo the operation and notice that it might either glitch and show the previous state then the new state, or it might not show the new state until you stop holding down ctrl or cmd on mac.

I also simplified the rendering logic a bit, check the commits for clarification about what does what.

@MrStevns MrStevns added this to the v0.6.7 milestone Apr 10, 2024
@chchwy
Copy link
Member

chchwy commented Apr 11, 2024

Confirmed the issue is fixed.

@chchwy chchwy self-requested a review April 11, 2024 08:52
@MrStevns
Copy link
Member Author

Thanks Matt!

@MrStevns MrStevns merged commit f741205 into pencil2d:master Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants