Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable C++17 by default when building against Qt 6 #1825

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Apr 23, 2024

Also cleans up other compiler options a bit:

  • use strict_c/c++ QMake feature to disable compiler extensions instead of messing directly with compiler flags
  • same with msvc_mp and utf8_source. the latter also does compiler detection so there should be no need for special handling of legacy builds
  • -stdlib=libc++ for macOS is removed since it appears to be the default since Qt 5.1
  • QMAKE_LINK{,_SHLIB} = $$QMAKE_CXX also appears to be the default

@J5lx J5lx added this to the 0.7.0 milestone Apr 23, 2024
@J5lx
Copy link
Member Author

J5lx commented Apr 23, 2024

macOS build failures are unrelated and will be fixed by #1823.

util/common.pri Outdated Show resolved Hide resolved
@chchwy chchwy self-requested a review April 24, 2024 10:25
@chchwy chchwy merged commit b09d081 into pencil2d:master Apr 24, 2024
8 checks passed
@J5lx J5lx deleted the qt6-c++17 branch April 24, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants