Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new reward/reward-distribution pallets to foucoco and amplitude #335

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

gianfra-t
Copy link
Contributor

Closes #314.

Adds the new pooled-reward and reward-distribution pallets to Foucoco and Amplitude runtimes.

As was discussed previously in the implementation, PoolId is set to CurrencyId and StakeId is set to VaultId

For now the new value of MaxRewardCurrencies of the staking pallet is set to 10.

@gianfra-t gianfra-t linked an issue Nov 6, 2023 that may be closed by this pull request
@gianfra-t gianfra-t requested review from ebma and b-yap November 8, 2023 12:56
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but we should use other values. The comments apply to both amplitude and foucoco.

runtime/amplitude/src/lib.rs Outdated Show resolved Hide resolved
runtime/amplitude/src/lib.rs Outdated Show resolved Hide resolved
runtime/amplitude/src/lib.rs Outdated Show resolved Hide resolved
@gianfra-t gianfra-t mentioned this pull request Nov 9, 2023
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now 👍

@gianfra-t gianfra-t requested a review from ebma November 13, 2023 14:14
@gianfra-t gianfra-t merged commit af6cc23 into main Nov 13, 2023
2 checks passed
@gianfra-t gianfra-t deleted the 314-add-the-new-spacewalk-pallets branch November 13, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the new Spacewalk pallets
2 participants