Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Turn off autoComplete for Back to Stellar address input #339

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

Sharqiewicz
Copy link
Collaborator

What:

Filling in the Redeem form tries to autofill with personal credentials. Expected behaviour is that the form does not autofill with this data.

How:

Implement autoComplete="off" for the input.

Closes: #163

@Sharqiewicz Sharqiewicz linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 4eeae94
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/65cf46432f84db000859aac0
😎 Deploy Preview https://deploy-preview-339--rococo-souffle-a625f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gonzamontiel
Copy link
Contributor

Okay, I am not sure about this one. What if you regularly paste your stellar address want that autofilled? Anyway, I don't experience this in my browser but if it's very annoying to you, I won't complain.

@Sharqiewicz Sharqiewicz merged commit ce8418f into staging Feb 19, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 163-redeem-autofill-with-personal-data branch February 19, 2024 14:06
@ebma
Copy link
Member

ebma commented Mar 15, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ebma ebma added the released label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redeem - Autofill with personal data
3 participants