fix: add balance left for tx approval: staking #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sharqiewicz
changed the title
ebma
requested changes
Feb 23, 2024
ebma
pushed a commit
that referenced
this pull request
Mar 14, 2024
# [1.3.0](v1.2.1...v1.3.0) (2024-03-14) ### Bug Fixes * add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909)) * add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594)) * handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049)) * Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240)) * Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993)) * Update disclaimer text for bridge ([692001e](692001e)) * Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94)) ### Features * 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11)) * Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e)) * Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd)) * Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019)) * added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce)) * create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a)) * enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5)) * Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d)) * Metamask Snap integration ([#315](#315)) ([978c515](978c515)) * nabla UI and functionality ([#279](#279)) ([331aabe](331aabe)) * Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd)) * Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4)) * Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0)) * Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5)) * Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791)) ### Reverts * Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
ebma
pushed a commit
that referenced
this pull request
Mar 15, 2024
# [1.3.0](v1.2.1...v1.3.0) (2024-03-15) ### Bug Fixes * add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909)) * add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594)) * handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049)) * Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240)) * Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993)) * Update disclaimer text for bridge ([692001e](692001e)) * Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94)) ### Features * 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11)) * Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e)) * Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd)) * Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019)) * added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce)) * create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a)) * enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5)) * Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d)) * Metamask Snap integration ([#315](#315)) ([978c515](978c515)) * nabla UI and functionality ([#279](#279)) ([331aabe](331aabe)) * Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd)) * Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4)) * Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0)) * Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5)) * Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791)) ### Reverts * Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
ebma
pushed a commit
that referenced
this pull request
Mar 15, 2024
# [1.3.0](v1.2.1...v1.3.0) (2024-03-15) ### Bug Fixes * add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909)) * add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594)) * handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049)) * Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240)) * Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993)) * Update disclaimer text for bridge ([692001e](692001e)) * Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94)) ### Features * 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11)) * Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e)) * Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd)) * Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019)) * added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce)) * create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a)) * enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5)) * Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d)) * Metamask Snap integration ([#315](#315)) ([978c515](978c515)) * nabla UI and functionality ([#279](#279)) ([331aabe](331aabe)) * Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd)) * Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4)) * Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0)) * Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5)) * Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791)) ### Reverts * Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When user decides to stakes with "MAX" button, the entire PEN balance is considered in that transaction leaving no tokens for the user to execute the transaction i.e no gas fees to execute the transaction
How:
Add BALANCE_LEFT_FOR_TX_APPROVAL constant variable.
Closes: #296