Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable the spacewalk option from menu on pendulum network #347

Conversation

Sharqiewicz
Copy link
Collaborator

@Sharqiewicz Sharqiewicz commented Feb 21, 2024

What:

Enable the Spacewalk option from menu on Pendulum network

How:

✅ organize the connect function in NodeInformationProvider into smaller functions
✅ enable Spacewalk for Pendulum in the Layout/links
✅ do not display tryConvertCodeToAscii error in the console
✅ removed unused hooks/spacewalk/index.tsx file
✅ Implemented a toast with an error message in Spacewalk > Bridge when Could not establish connection with the bridge
✅ do not display 'undefined' when the token symbol in the bridge could not be loaded
✅ change the name of vaultRegistry hook to useVaultRegistryPallet due to 'use' hook naming convention

Closes: #333

@Sharqiewicz Sharqiewicz linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 979c3da
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/65df27100949b80008ba3260
😎 Deploy Preview https://deploy-preview-347--rococo-souffle-a625f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz Sharqiewicz changed the title 333 enable the spacewalk option from menu on pendulum network feat: enable the spacewalk option from menu on pendulum network Feb 21, 2024
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring looks good to me, nice job 👌
If you renamed the file for the vault registry pallet to align with hook naming conventions then let's also do it for the others, or is there a reason you chose not to?

src/hooks/spacewalk/useBridgeSettings.ts Outdated Show resolved Hide resolved
@Sharqiewicz
Copy link
Collaborator Author

Sharqiewicz commented Feb 23, 2024

@ebma I'll rename the other hooks as well then

Copy link
Contributor

@gonzamontiel gonzamontiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. LGTM

@Sharqiewicz Sharqiewicz merged commit e2108f5 into staging Feb 29, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 333-enable-the-spacewalk-option-from-menu-on-pendulum-network branch February 29, 2024 09:33
ebma pushed a commit that referenced this pull request Mar 14, 2024
# [1.3.0](v1.2.1...v1.3.0) (2024-03-14)

### Bug Fixes

* add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909))
* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a))
* enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* Metamask Snap integration ([#315](#315)) ([978c515](978c515))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
ebma pushed a commit that referenced this pull request Mar 15, 2024
# [1.3.0](v1.2.1...v1.3.0) (2024-03-15)

### Bug Fixes

* add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909))
* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a))
* enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* Metamask Snap integration ([#315](#315)) ([978c515](978c515))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
ebma pushed a commit that referenced this pull request Mar 15, 2024
# [1.3.0](v1.2.1...v1.3.0) (2024-03-15)

### Bug Fixes

* add balance left for tx approval: staking ([#343](#343)) ([cd87909](cd87909))
* add Buffer polyfill to window global object ([#346](#346)) ([98e6594](98e6594))
* handle walletconnect disconnect events ([#338](#338)) ([738d049](738d049))
* Implement collapsible buttons for sidebar ([#337](#337)) ([d9c9240](d9c9240))
* Make Staking Reward boxes responsive ([#324](#324)) ([e765993](e765993))
* Update disclaimer text for bridge ([692001e](692001e))
* Update disclaimer text for Spacewalk ([#303](#303)) ([70c2a94](70c2a94))

### Features

* 288 allow users to withdraw from backstop pool in other assets ([#292](#292)) ([8322b11](8322b11))
* Add AMPE price to the Dashboard ([#293](#293)) ([cdf598e](cdf598e))
* Add info to the Bedeem from Backstop pool UI ([#291](#291)) ([208dacd](208dacd))
* Add support for NGN, EUR and AUD assets for Spacewalk ([#302](#302)) ([c377019](c377019))
* added pool filtering by paused flag ([#289](#289)) ([6e09bce](6e09bce))
* create decimal parseNumber implementation ([#349](#349)) ([49b194a](49b194a))
* enable the spacewalk option from menu on pendulum network ([#347](#347)) ([e2108f5](e2108f5))
* Make rows clickable in Spacewalk Transfers table ([#323](#323)) ([acb6b3d](acb6b3d))
* Metamask Snap integration ([#315](#315)) ([978c515](978c515))
* nabla UI and functionality ([#279](#279)) ([331aabe](331aabe))
* Remove mainnet USDC asset from AssetSelector in Foucoco ([#353](#353)) ([0febbfd](0febbfd))
* Update designs for Staking/Unstaking ([#325](#325)) ([3d391b4](3d391b4))
* Update designs for Updating and Claiming staking rewards ([#336](#336)) ([2ebc5d0](2ebc5d0))
* Update Spacewalk dialogs for "Back to Stellar" transactions ([#305](#305)) ([c80d7a5](c80d7a5))
* Update transfer dialogs design ([#295](#295)) ([8fe2791](8fe2791))

### Reverts

* Put back GH_TOKEN into the release config ([#282](#282)) ([e2b142a](e2b142a))
@ebma
Copy link
Member

ebma commented Mar 15, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ebma ebma added the released label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the Spacewalk option from menu on Pendulum network
3 participants