Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display asset icons in AssetDropdownSelector #526

Conversation

Sharqiewicz
Copy link
Collaborator

✅ Add with getIcon() to DropdownSelector

@Sharqiewicz Sharqiewicz requested review from ebma and prayagd July 19, 2024 18:01
@Sharqiewicz Sharqiewicz linked an issue Jul 19, 2024 that may be closed by this pull request
1 task
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit f04808e
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/669aaa13e431dc000889366a
😎 Deploy Preview https://deploy-preview-526--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@prayagd prayagd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ebma ebma merged commit 830ac3b into main Jul 22, 2024
5 checks passed
@ebma ebma deleted the 486-add-icons-for-assets-to-the-dropdown-for-spacewalk-on-amplitude-and-pendulum branch July 22, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icons for assets to the dropdown for Spacewalk on Amplitude and Pendulum
3 participants