Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect to AlchemyPay #543

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Fix redirect to AlchemyPay #543

merged 7 commits into from
Aug 30, 2024

Conversation

ebma
Copy link
Member

@ebma ebma commented Aug 29, 2024 •
edited
Loading

  • Creates a new netlify function that has access to the required parameters to sign the query parameters for showing PEN by default on the AlchemyPay dashboard.
  • Refactor code to allow for asynchronous generation of navigation links

Closes #536 and closes https://github.com/pendulum-chain/tasks/issues/382

@ebma ebma linked an issue Aug 29, 2024 that may be closed by this pull request
Make new changes to the PEN onramp #536
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 200787c
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66d1be5a2a74a7000866ceef
😎 Deploy Preview https://deploy-preview-543--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ebma ebma changed the title WIP Make new changes to the pen onramp Fix redirect to AlchemyPai Aug 29, 2024
@ebma ebma changed the title Fix redirect to AlchemyPai Fix redirect to AlchemyPay Aug 29, 2024
@ebma ebma requested a review from a team August 29, 2024 17:25
TorstenStueber
TorstenStueber reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution with the Netlify function. Just one remark about making the menu available earlier in case the function loads or works slowly... (at least for AWS Lambda this is the case after some inactivity).

@ebma ebma merged commit 7b31593 into main Aug 30, 2024
5 checks passed
@ebma ebma deleted the 536-make-new-changes-to-the-pen-onramp branch August 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenStueber TorstenStueber TorstenStueber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make new changes to the PEN onramp
2 participants
@ebma @TorstenStueber