Chore/update packages (Ready) #597
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sharqiewicz
changed the title
|
@ebma Ready for review |
There was a problem hiding this comment.
Great changes, looks good to me 👍
If we need luxon package. We use it only once.
I'm fine to remove it, we just need to replace that one function call with custom logic.
If we need Babel for JEST. Our transpiler is esbuild, we don't need Babel for transpilation. Our testing enviroment was configured long time ago to use Babel. I think we should consider changing it to remove Babel from our repo. (it creates confusion) - create a task
Agreed. Can you create the task @Sharqiewicz?
Move from react-lottie to react-lottie-player ( react-lottie-player doesn't use eval )
What's the benefit?
When linting, I always get the error
yarn lint
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0
YOUR TYPESCRIPT VERSION: 5.6.3
Please only submit bug reports when using the officially supported version.
Should we consider upgrading our eslint dependencies, or did you look into this and there is not much we can do at the moment @Sharqiewicz?
|
I created tasks:
‘eval’ is a pass-through for XSS attacks, the best practice is to always eliminate it from the application. |
|
Cool 👍 how about you tackle those issues in about a month when the monthly reminder fires again? |
|
@ebma I think we can ignore the warning. We won't use any TS features from versions greater than 5.5.0 |
|
created task for react-lottie package replacement: #603 |
|
@ebma I think it's ready |
|
Nice, let's go 🚀 Edit: Okay, actually it might make sense to have the @pendulum-chain/product also have a quick look and briefly test all features to make sure we are not missing some sneaky regressions due to the update. |
|
@ebma what features to be tested all the portal features? |
Dumb question: How do i check if there are no regressions? |
|
@prayagd I think in order to test if there is no regression, we have to ensure that every Portal feature is working correctly. So we should test staking, forex amm and spacewalk |
|
Will do |
Yes exactly, that's what I meant. Thanks @Sharqiewicz for pointing it out and @prayagd for testing. |
🦈 The goal of the PR is to update all the outdated packages. Some of them are even 18 months old.
👷 Removed packages
To investigate:
luxonpackage. We use it only once.esbuild, we don't need Babel for transpilation. Our testing enviroment was configured long time ago to use Babel. I think we should consider changing it to remove Babel from our repo. (it creates confusion) - create a taskreact-lottietoreact-lottie-player(react-lottie-playerdoesn't use eval )I did not
Changed the minimum version of yarn to be
>=4.0.0Note: Recent DaisyUI generates css-syntax-error on build. Can be ignored.