Code

Fix Informational Issues#385

Code

Merged

ebma merged 29 commits intomainpendulum-chain/spacewalk:mainfrom 257-fix-informational-issuespendulum-chain/spacewalk:257-fix-informational-issuesCopy head branch name to clipboardOct 12, 2023

+3,893-2,962

Commits

Commits on Sep 26, 2023

• SYT-03 | Unnecessary Variable

  b-yap

  committed
  0efabd1

  Copy full SHA for 0efabd1

• STL-03 | Lack of Validation for destination_address on send_payment_to_address()

  b-yap

  committed
  f9adcac

  Copy full SHA for f9adcac

• SRL-01 | Usage of Hard-coded Strings

  b-yap

  committed
  3f58084

  Copy full SHA for 3f58084

• PAL-03 | Usage of Magic Numbers

  b-yap

  committed
  5eec0fa

  Copy full SHA for 5eec0fa

• PAL-02 | Unnecessary Result<...> Return Type

  b-yap

  committed
  9d65f64

  Copy full SHA for 9d65f64

• CLI-02 | Typos

  b-yap

  committed
  e609b4d

  Copy full SHA for e609b4d

• 9B2-03 | Unused Errors

  b-yap

  committed
  7f0c221

  Copy full SHA for 7f0c221

• code cleanup for PAL-03 | Usage of Magic Numbers

  b-yap

  committed
  707f706

  Copy full SHA for 707f706

• code cleanup for PAL-02 | Unnecessary Result<...> Return Type

  b-yap

  committed
  06a71e8

  Copy full SHA for 06a71e8

• partial of 9B2-04 | Logic Should be Moved To an Separate Function - Refactoring;

  Show description for 4b371b0
  b-yap

  committed
  4b371b0

  Copy full SHA for 4b371b0

• code cleanup

  b-yap

  committed
  1883217

  Copy full SHA for 1883217

• https://github.com/pendulum-chain/spacewalk/pull/385#discussion_r1301837649,

  Show description for b8c5852
  b-yap

  committed
  b8c5852

  Copy full SHA for b8c5852

• https://github.com/pendulum-chain/spacewalk/pull/385#discussion_r1301935159

  b-yap

  committed
  ee53122

  Copy full SHA for ee53122

• Use vault vs user wallet in integration tests

  

  ebma

  authored and

  b-yap

  committed
  5526e5d

  Copy full SHA for 5526e5d

• fix Unable to get required collateral for amount issue

  b-yap

  committed
  c77a9c0

  Copy full SHA for c77a9c0

• https://github.com/pendulum-chain/spacewalk/pull/385#discussion_r1303161473

  b-yap

  committed
  229a647

  Copy full SHA for 229a647

• removing the "last_known_cursor" and let the CI run it

  b-yap

  committed
  9479d25

  Copy full SHA for 9479d25

• https://github.com/pendulum-chain/spacewalk/actions/runs/5972713032/job/16203688884#step:9:144

  b-yap

  committed
  ea2f489

  Copy full SHA for ea2f489

• Fix test_replace_succeeds test case

  

  ebma

  authored and

  b-yap

  committed
  a17d0b1

  Copy full SHA for a17d0b1

• fix test case due to changed HorizonSubmissionError

  b-yap

  committed
  0b43167

  Copy full SHA for 0b43167

• 257 FIx Informational Issues - Logic Should be Moved To an Separate Function - Refactoring (#388)

  Show description for ba47b68
  b-yap

  committed
  ba47b68

  Copy full SHA for ba47b68

• 257 Fix informational issues part 3 (#390)

  Show description for 415542f
  b-yap

  committed
  415542f

  Copy full SHA for 415542f

• from https://github.com/pendulum-chain/spacewalk/pull/392/files#diff-0f76594421d4493b3bba1c9ed7864cdab7148f19c5d3a18a9bcc9a174bb85aa8

  b-yap

  committed
  f21b5df

  Copy full SHA for f21b5df

Commits on Sep 27, 2023

• from https://github.com/pendulum-chain/spacewalk/pull/392/files#diff-0f76594421d4493b3bba1c9ed7864cdab7148f19c5d3a18a9bcc9a174bb85aa8

  b-yap

  committed
  8e58b63

  Copy full SHA for 8e58b63

Commits on Oct 11, 2023

• 257 fix informational issues part 4 (#393)

  Show description for 7589b69
  b-yap

  authored
  7589b69

  Copy full SHA for 7589b69

Commits on Oct 12, 2023

• https://github.com/pendulum-chain/spacewalk/actions/runs/6482197215/job/17610217546?pr=385#step:12:560

  b-yap

  committed
  c51d07b

  Copy full SHA for c51d07b

• https://github.com/pendulum-chain/spacewalk/actions/runs/6491793772/job/17629635299?pr=385#step:11:58

  b-yap

  committed
  b443b87

  Copy full SHA for b443b87

• fix clippy issues

  b-yap

  committed
  611cc5f

  Copy full SHA for 611cc5f

• cargo fmt --all

  b-yap

  committed
  b57ca7b

  Copy full SHA for b57ca7b