Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

421 fix failing runner test #424

Merged
merged 3 commits into from
Oct 17, 2023
Merged

421 fix failing runner test #424

merged 3 commits into from
Oct 17, 2023

Conversation

b-yap
Copy link
Contributor

@b-yap b-yap commented Oct 17, 2023

closes #421 .

@b-yap b-yap requested a review from a team October 17, 2023 08:17
@b-yap b-yap marked this pull request as ready for review October 17, 2023 08:18
gianfra-t
gianfra-t approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me!

@b-yap b-yap merged commit 5345a9a into main Oct 17, 2023
2 checks passed
@b-yap b-yap deleted the 421-fix-failing-runner-test branch October 17, 2023 13:03
@ebma ebma mentioned this pull request Oct 17, 2023
Closed
b-yap added a commit that referenced this pull request Oct 25, 2023
@b-yap
421 fix failing runner test (#424)
c6dd648 
* first iteration

* fix 2 failing runner tests

* fix last failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianfra-t gianfra-t gianfra-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing runner test
2 participants
@b-yap @gianfra-t