Rewards pallet-integration tests #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with different types
… new configuration to necessary mock runtimes
… defined currencyid in config
…store of calculated percentages in pallet
…walk into reward-pallet-tests
…walk into reward-pallet-tests
ebma
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thanks for addressing the requested changes @gianfra-t, I really like the tests and the explicit calculations. I added some nitpicky comments again but it looks good to me overall. Great job 👍
ebma
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM. Thanks for addressing all my comments and great job overall @gianfra-t 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #423.
As discussed in the issue, we need to ensure the proper issuance and distribution of the fee and per block reward tokens.
This is tested as follows:
In the
vault-registrypallet, used due to the fact that it already has functions, constants and genesis configs appropriate to deploy vaults, we test here the block reward distribution. This is done in theseintegration_*test functions. These tests cover the registry of a vault, execution of the on init function (called directly) and assertion that the vault owners can collect the rewards.In the
issuepallet, given that it has the proper mocks for issuing and triggering the fee distribution, we test in theseintegrationmodule tests, we ensure that the fees are distributed to the many collateral registered vaults, and that all the vaults in thepooled-rewardpallet receive these rewards accordingly. (also have in mind the price mock for this example distribution).On the same module, we also test that nominated vault is taken into account and that the nominator gets the proper rewards and can collect them.