Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

313 - retry integration tests for tx_bad_seq errors #447

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

b-yap
Copy link
Contributor

@b-yap b-yap commented Nov 7, 2023

closes #313

General overview of the changes:

Created a loop for send_payment_to_address to keep resending the same transaction, should the error be tx_bad_seq error.
This is only for integration tests.

@b-yap b-yap marked this pull request as ready for review November 8, 2023 06:53
@b-yap b-yap requested a review from a team November 8, 2023 06:53
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I love it, good job @b-yap 👍

Did you do some testing for this locally and in CI?

@b-yap
Copy link
Contributor Author

b-yap commented Nov 9, 2023

@ebma yes I did.

@ebma
Copy link
Member

ebma commented Nov 9, 2023

Alright. I see that one of the jobs failed with

thread 'tests::stellar_overlay_disconnect_works' panicked at 'Incorrect stellar relay message received', clients/stellar-relay-lib/src/tests/mod.rs:182:9

but that's unrelated to the integration tests. Should we create an extra ticket for this?

Since the other actions worked well, I guess we can merge this already.

@b-yap
Copy link
Contributor Author

b-yap commented Nov 10, 2023

@ebma since it occurred twice (here and Zoltan's) now then yes i agree about an extra ticket.

@b-yap b-yap merged commit 479ec0e into main Nov 10, 2023
2 checks passed
@b-yap b-yap deleted the 313-retry-transaction-submission-in-integration-tests branch November 10, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry transaction submission in integration tests
2 participants