Upgrade to Polkadot v1.6.0 #569

gianfra-t · 2024-11-25T14:41:21Z

Closes #567.

Main changes

Bump all polkadot-sdk dependencies to 1.6.0.
Move dependencies to workspace.
Update chain_spec due to deprecated ChainSpec::from_genesis(.....) method.
Update node.

…partially), stellar-relay-lib

ebma

I think for some dependencies there is now a mismatch of how the default-features were configured.

clients/runner/Cargo.toml

clients/runtime/Cargo.toml

clients/vault/Cargo.toml

pallets/currency/Cargo.toml

pallets/oracle/Cargo.toml

ebma · 2024-12-04T10:35:16Z

clients/vault/resources/config/mainnet/stellar_relay_config_frankfurt.json

-    "https://stellar-history-de-fra.satoshipay.io",
-    "https://stellar-history-sg-sin.satoshipay.io",
-    "https://stellar-history-us-iowa.satoshipay.io"
+    "https://hercules-history.publicnode.org"


Did you change this due to the 'overloaded' issue or for a different reason? If so, you'd rather need to change the address field in connection_info to the host you can also find in Stellarbeat. If not, I'll leave this comment as a reminder that we should change it back eventually.

Yes, although the only one used to reduce uncertainty is the "other" config. It seems to be okay for our main test.

Back to original configs now.

gianfra-t · 2024-12-05T16:07:22Z

clients/wallet/src/horizon/responses.rs

@@ -202,8 +202,6 @@ pub struct TransactionResponse {
 	#[serde(deserialize_with = "de_str_to_bytes")]
 	pub result_xdr: Vec<u8>,
 	#[serde(deserialize_with = "de_str_to_bytes")]
-	pub result_meta_xdr: Vec<u8>,


Deprecated field (see here).

gianfra-t · 2024-12-05T17:21:45Z

primitives/src/lib.rs

@@ -529,10 +529,15 @@ impl Asset {
 #[allow(clippy::unnecessary_cast)]
 pub enum CurrencyId {
 	#[default]
+	#[serde(rename = "Native")]


This changes may be significant. The particular reason I added these (and removed the camelCase renaming above), is now due to the following panic:

Client(Storage("Invalid JSON blob: unknown variant `xCM`, expected one of `Native`, `XCM`, `Stellar`, `ZenlinkLPToken`, `Token` at line 1 column 2105"))

which appears when running the chain binary.

This comes from the changes in how the chain spec is defined now (first serialized in a json format).
I believe this error was also an issue for some extrinsics. @pendulum-chain/devs do you know if this renaming could impact some downstream services?

I also remember that error you are referring to. I think changing it the way you did makes sense.

This could break some polkadot.js types as at least the XCM type seems to be sometimes referred to as Xcm see here. Elsewhere it's used as XCM though, see here, so maybe it's not a big deal. We'll see but can easily fix the problem by upgrading the types in pendulum.js.

I see. Why did the pendulum types worked as Xcm and not xCM is a mystery then. But this serialization is only relevant when compiled with std. In any case, let's hope is not a big deal.

gianfra-t · 2024-12-05T17:34:35Z

testchain/node/Cargo.toml

-serde_json = "1.0.85"
-futures = "0.3.15"
-tokio = { version = "1.37", features = ["full", "tracing"] }
+clap = { version = "4.5.3", features = [ "derive" ] }


Node requires a higher version of clap compared to that used in the workspace.

gianfra-t · 2024-12-05T18:25:32Z

@pendulum-chain/devs the CI may get stuck on the integration tests sometimes (with integration tests never ending, unknown reason. Example), yet locally I was able to run successfully all of them.

I believe this does not have to do with the update itself.

ebma

Looks good to me. I left only very minor comments.

ebma · 2025-01-08T15:38:23Z

testchain/node/Cargo.toml

-futures = "0.3.15"
-tokio = { version = "1.37", features = ["full", "tracing"] }
+clap = { version = "4.5.3", features = [ "derive" ] }
+codec = { workspace = true, default-features = true, version = "3.0.0" }


How come we define workspace = true but still define a custom version?

Was not correct. Seems that it was ignored anyway.

ebma · 2025-01-08T15:40:48Z

zepter.yaml

+# Will be displayed when any workflow fails:
+help:
+  text: |
+    Polkadot-SDK uses the Zepter CLI to detect abnormalities in the feature configuration.


Nit: we could change this message. Doesn't matter much.

ebma · 2025-01-08T15:42:11Z

pallets/issue/rpc/Cargo.toml

@@ -5,9 +5,9 @@ authors = ["Interlay <[email protected]>"]
 edition = "2021"

 [dependencies]
-codec = { package = "parity-scale-codec", version = "3.0.0" }
+codec = { workspace = true, default-features = true }
 jsonrpsee = { version = "0.16.0", features = ["client", "server", "macros"] }


Do we need this custom version or would it also work with the one in workspace?

We probably don't "need" that version, but upgrading it involves making changes to each module's rpc code that we didn't have much time to go through.

ebma · 2025-01-08T15:43:04Z

testchain/node/Cargo.toml


-substrate-stellar-sdk = { git = "https://github.com/pendulum-chain/substrate-stellar-sdk", branch = "polkadot-v1.1.0" }
+substrate-stellar-sdk = { workspace = true, default-features = true }

 # RPC dependencies
 jsonrpc-core = "18.0.0"


Would the workspace dependencies not work?

Let me try. It could be that I or zepter missed them for some reason.

Similar to this, or in fact the same. It will require more changes to the node.

gianfra-t · 2025-01-09T12:40:48Z

Let's keep the branch for now, until we fully change every dependency to point to main.

gianfra-t added 15 commits November 19, 2024 15:34

create base workspace dependencies, update runner, runtime, service (…

b12f5b0

…partially), stellar-relay-lib

updated vault, cargo check only

39f922b

upgrade pallet clients-info

e09ed14

upgrade currency pallet, using maybe temporary orml fork

60d6d56

upgrade pallet security, remove mocktopus, upgrade fee (cargo check)

7baf14e

upgrade staking, oracle

115068a

update stellar-relay, pooled-reards

f2d328e

add mocktopus again

61b053c

fixes for mocktopus error, finish upgrade oracle pallet

3c6fbdc

fix and re-add mocktopus

423f62d

upgrade, vault-registry

2cf0d25

upgrade nomination, redeem, issue

e87ff26

upgrade replace, reward

6a774ac

updating runtimes, wip

45a69d5

upgrade node, mainnet toml

b027527

gianfra-t force-pushed the polkadot-v1.6.0 branch from 8dd4977 to b027527 Compare November 25, 2024 17:24

ebma reviewed Nov 26, 2024

View reviewed changes

gianfra-t added 2 commits November 26, 2024 09:26

fix incorrect features flags, sha2 api change

820a064

checking runtimes, default-features fixes

8875c79

gianfra-t force-pushed the polkadot-v1.6.0 branch from f61e104 to 8875c79 Compare November 26, 2024 17:24

upgrade node

d3b5817

gianfra-t force-pushed the polkadot-v1.6.0 branch from 586ba8b to d3b5817 Compare November 27, 2024 16:51

gianfra-t added 3 commits November 27, 2024 17:02

fix chain spec definition

b86d117

fmt and clippy

f9a6d42

install rust-src for nightly also

c32f9ca

gianfra-t force-pushed the polkadot-v1.6.0 branch from 6db2462 to c32f9ca Compare November 28, 2024 17:52

update stellar relay configs

4e521dd

gianfra-t force-pushed the polkadot-v1.6.0 branch 2 times, most recently from b936acb to b6184bf Compare November 29, 2024 15:41

fixes for test issues

1f582d1

gianfra-t force-pushed the polkadot-v1.6.0 branch from 09d24bd to 85eeabf Compare December 3, 2024 10:44

test only integration on CI

000118d

gianfra-t force-pushed the polkadot-v1.6.0 branch from 85eeabf to 000118d Compare December 3, 2024 11:10

gianfra-t mentioned this pull request Dec 3, 2024

[TEST- DO NOT MERGE] Baseline 1.6.0 tests #570

Closed

ebma reviewed Dec 4, 2024

View reviewed changes

gianfra-t and others added 3 commits December 4, 2024 11:05

fix testnet_config spec

3f68792

fix spec definition

8cc27db

Add #[serde(skip)] to phantom definitions

aaf57c7

gianfra-t changed the title ~~WIP. Upgrade to Polkadot v1.6.0~~ Upgrade to Polkadot v1.6.0 Dec 4, 2024

gianfra-t added 2 commits December 4, 2024 16:53

cleanup, fmt

019be8c

remove other node

5a26b6a

gianfra-t commented Dec 5, 2024

View reviewed changes

gianfra-t added 2 commits December 5, 2024 14:36

more cleanup

fa97c08

regenerate metadata

289c845

gianfra-t marked this pull request as ready for review December 5, 2024 18:23

gianfra-t requested a review from a team December 5, 2024 18:23

gianfra-t added 3 commits December 5, 2024 16:43

re-introduce patch

13c2bdf

run zepter

53525ba

re-add offchain features substrate-stellar-sdk

8e7f637

gianfra-t force-pushed the polkadot-v1.6.0 branch from 70beae6 to 8e7f637 Compare December 10, 2024 12:02

generated metadata with 1.6.0 runtimes

35abbbc

ebma approved these changes Jan 8, 2025

View reviewed changes

fix incorrect dependency version

c8a0201

gianfra-t merged commit 7626b16 into main Jan 9, 2025
3 of 4 checks passed

gianfra-t deleted the polkadot-v1.6.0 branch January 9, 2025 12:38

gianfra-t restored the polkadot-v1.6.0 branch January 9, 2025 12:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Polkadot v1.6.0 #569

Upgrade to Polkadot v1.6.0 #569

gianfra-t commented Nov 25, 2024 •

edited

Loading

ebma left a comment

ebma Dec 4, 2024

gianfra-t Dec 4, 2024

gianfra-t Dec 5, 2024

gianfra-t Dec 5, 2024

gianfra-t Dec 5, 2024 •

edited

Loading

ebma Jan 8, 2025

gianfra-t Jan 8, 2025

gianfra-t Dec 5, 2024

gianfra-t commented Dec 5, 2024 •

edited

Loading

ebma left a comment

ebma Jan 8, 2025

gianfra-t Jan 8, 2025

ebma Jan 8, 2025

ebma Jan 8, 2025

gianfra-t Jan 8, 2025

ebma Jan 8, 2025

gianfra-t Jan 8, 2025

gianfra-t Jan 8, 2025

gianfra-t commented Jan 9, 2025

Upgrade to Polkadot v1.6.0 #569

Upgrade to Polkadot v1.6.0 #569

Conversation

gianfra-t commented Nov 25, 2024 • edited Loading

Main changes

ebma left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gianfra-t Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gianfra-t commented Dec 5, 2024 • edited Loading

ebma left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gianfra-t commented Jan 9, 2025

gianfra-t commented Nov 25, 2024 •

edited

Loading

gianfra-t Dec 5, 2024 •

edited

Loading

gianfra-t commented Dec 5, 2024 •

edited

Loading