Improve UI on log-in modal. #350
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gianfra-t
changed the title
gianfra-t
changed the title
gianfra-t
changed the title
| @@ -368,7 +374,7 @@ export const SwapPage = () => { | |||
| from, | |||
| selectedNetwork, | |||
| fromAmountString, | |||
| requiresSquidRouter: selectedNetwork === Networks.Polygon, | |||
| requiresSquidRouter: isNetworkEVM(selectedNetwork), | |||
There was a problem hiding this comment.
Not related to this change, but we need this after support of other EVM networks.
There was a problem hiding this comment.
I tested it. Works overall 👍 I pushed a commit to add the progress bar and footer also for the login. IMO it looks better with both indicators and there is no need to hide them. I put the progress of the login to 15% by default so that it's clearer that the progress bar is indicating progress which is not clear with an empty bar.
I think we should spend more time on re-thinking the retry button. It's a nice feature overall but I wouldn't merge it the way it is. The concern I have is that when I reject a signature and click on the retry button, I would expect that the app continues where it stopped, ie. it would ask me to sign again. This is not the case at the moment and I need to click on the 'Confirm' button again. It doesn't seem like a big deal but would only lead to confusion if we don't do it properly. I propose we remove the retry button from this PR and discuss with the product team.
|
@ebma I removed the retry button. Also we discussed we wanted to add a toast when detecting user rejection, and just reset the app. So that type of error is not shown on the UI now. |
Co-authored-by: Marcel Ebert <[email protected]>
Closes: #351 (and #362)
A re-use of the signing box needs to show when the user attempts to login. This box should not show a progress bar on this stage.
Changes
SigningBoxcomponent to allow for this new "phase". Amount of signatures to display are adjusted depending on the phase. Also an animation would rapidly load the progress bar to 100% after finish all signatures, to "dampen" the sudden dismissal of the box.useSiweSignaturehook to work without the modal.sep24variables upon network change. This resets the state and allow the user to click confirm again.