-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Migrate from Preact to React #407
[READY] Migrate from Preact to React #407
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pendulum-chain/devs Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sharqiewicz ! I hope modifying the types was not such a hurdle.
I tested the translation to Spanish on Firefox and it looks good except for what @prayagd already found, but also I attach a screenshot:
Any clue why "Sell" is being translated to "Vdear" and not "Vender"? I don't know if there is something we can do about it even.
@prayagd @ebma @gianfra-t
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Sharqiewicz 🙏 I also tested it and it looks good to me. I didn't see any duplicate words. I noticed that the dialog for the Substrate wallet connection remains in English but I don't think this is a dealbreaker and we can live with this.
Let's merge this on Friday as we shouldn't risk our Thursday release due to unforeseen side-effects with the package changes.
…he-vortex-app-from-preact-to-react
updated packages:
Changes were pretty straightforward