Fix empty relay state (#5) #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okta sends an empty relay state, if none is provided. This generates an error, as the key is present in the post data, and by design different from the current URL. So we try to redirect to the empty URL. Also tuck the relaystate into a variable for readability and provide a test for this case.
|
I will try to give this a review later today, thanks for your contribution! |
ngearhart
requested changes
Jul 25, 2022
ngearhart
approved these changes
Jun 20, 2023
|
1 year later, I think this is good to go - but the version update PR needs merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okta sends an empty relay state, if none is provided. This generates an
error, as the key is present in the post data, and by design different
from the current URL. So we try to redirect to the empty URL.
Also tuck the relaystate into a variable for readability and provide a
test for this case.