Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shared Actions #546

Closed
wants to merge 2 commits into from
Closed

Use Shared Actions #546

wants to merge 2 commits into from

Conversation

joyliu-q
Copy link
Contributor

@joyliu-q joyliu-q commented Oct 7, 2022

Use shared CI/CD from Penn Labs' shared actions.

With this, developers can gain experience with using GitHub workflows, while maintaining the abstractions that Kraken provided.

Also, in emergency situations, we can enable skipChecks (similar to the feature suggested by PR pennlabs/infrastructure#157).

@joyliu-q joyliu-q requested a review from rohangpta October 7, 2022 18:39
Copy link
Member

@rohangpta rohangpta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Joy!

@joyliu-q joyliu-q marked this pull request as draft October 11, 2022 16:59
@rohangpta
Copy link
Member

LGTM thanks Joy!

@joyliu-q Looking through old PRs on Penn Clubs, why was this marked as a draft? Just wondering

@joyliu-q
Copy link
Contributor Author

Closed to favor #570

@joyliu-q joyliu-q closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants