-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to open and close ticket sales #766
Conversation
for item in quantities: | ||
if item.get("count", 0) <= 0: | ||
return Response( | ||
{"detail": "Ticket quantities must be positive", "success": False}, | ||
status=status.HTTP_400_BAD_REQUEST, | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is unrelated to the PR. Just noticed that we weren't checking that quantities being added to the cart were positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid PR! LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ticketing-v2 #766 +/- ##
================================================
+ Coverage 72.03% 72.08% +0.04%
================================================
Files 32 32
Lines 6977 6996 +19
================================================
+ Hits 5026 5043 +17
- Misses 1951 1953 +2 ☔ View full report in Codecov by Sentry. |
Adds route for club leaders to suspend and resume ticket sales. If an event has its ticket sales paused, buyers can no longer view it via
tickets
or add them to cart. (Note that checkout initiation and completion is unaffected for now, as these components are going to be reworked for #758.)Addresses #759.
(Note: when #762 is merged in, rebase this one to
ticketing-v2
.)