feat!: add disconnectTimeout option to rx-nostr config
#165
Conversation
packages/core/src/config/config.ts
Outdated
|
|
||
| /** | ||
| * How long a relay connection should be held open when no longer used | ||
| * @default 0 |
There was a problem hiding this comment.
Nice annotation👍. I will introduce this in other doc comments.
There was a problem hiding this comment.
Do you think it makes sense to add a default timeout of 10000 ( 10s )?
Currently rx-nostr makes a lot of connections to temporary relays or even the default ones when its set to lazy and its much smoother if it keeps the connections open for a while
I wanted to ask first since its maybe a breaking change
There was a problem hiding this comment.
As you mention, it is a breaking change but certainly makes sense. In my personal opinion I find it acceptable to include it in this minor update. Let's change it to 10000.
It will break some test cases so please set disconnectTimeout: 0 to fix them.
There was a problem hiding this comment.
@hzrd149 Do you change the default value in this PR? If not, I will merge soon.
There was a problem hiding this comment.
added a default of 10000 (10s) and updated the tests
packages/core/src/config/config.ts
Outdated
| @@ -48,6 +49,13 @@ export interface RxNostrConfig { | |||
| * Auto reconnection strategy. | |||
| */ | |||
| retry?: RetryConfig; | |||
|
|
|||
| /** | |||
| * How long a relay connection should be held open when no longer used | |||
There was a problem hiding this comment.
I think we should explain that it only affect lazy strategy relays and default relays.
|
@hzrd149 I think the implementation is very simple and great! Could you update the doc comment to show what relays the option affects? |
penpenpng
changed the title
disconnectTimeout option to rx-nostr config
penpenpng
changed the title
disconnectTimeout option to rx-nostr configdisconnectTimeout option to rx-nostr config
This is my best attempt at adding a disconnect timeout option to rx-nostr to address #164
Let me know if you think there is a better way to implement this but I think I made it pretty simple :)