Update LDAPConnection.java #8728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR to fix multiple issues on LDAP : - fetch all members of a ldap group with 1500+ members (Active directory returns null values for groups with 1500+ members when we don't specfiy a member;range=0-1500). So iterate multiple times to fetch n times all the members for the group - binary attributes are not treat well by pentaho. so we pass by a data: base64 encoded string feed - the ldap upsert step doesn't remove the attribute that have NULL values
This comment has been minimized.
This comment has been minimized.
❌ Build failed in 2m 3sBuild command: mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox❗ No tests found!ℹ️ This is an automatic message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to fix multiple issues on LDAP :
fetch all members of a ldap group with 1500+ members (Active directory returns null values for groups with 1500+ members when we don't specfiy an attribute member like this : member;range=0-1500).
The idea is to iterate multiple times to fetch n times all the members for the group
binary attributes are not treat well by pentaho. so we pass by a data: base64 encoded string feed.
the ldap upsert step doesn't remove the attribute that have NULL values