Disable custom truncate behavior

See rapidsai#104 for details.
pentschev · Oct 17, 2023 · 6ab8a62 · 6ab8a62
1 parent 8e8b764
commit 6ab8a62
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/cpp/src/request_tag.cpp b/cpp/src/request_tag.cpp
@@ -62,13 +62,14 @@ RequestTag::RequestTag(std::shared_ptr<Component> endpointOrWorker,
 
 void RequestTag::callback(void* request, ucs_status_t status, const ucp_tag_recv_info_t* info)
 {
-  if (status != UCS_ERR_CANCELED && info->length != _length) {
-    status          = UCS_ERR_MESSAGE_TRUNCATED;
-    const char* fmt = "length mismatch: %llu (got) != %llu (expected)";
-    size_t len      = std::snprintf(nullptr, 0, fmt, info->length, _length);
-    _status_msg     = std::string(len + 1, '\0');  // +1 for null terminator
-    std::snprintf(_status_msg.data(), _status_msg.size(), fmt, info->length, _length);
-  }
+  // TODO: Decide on behavior. See https://github.com/rapidsai/ucxx/issues/104 .
+  // if (status != UCS_ERR_CANCELED && info->length != _length) {
+  //   status          = UCS_ERR_MESSAGE_TRUNCATED;
+  //   const char* fmt = "length mismatch: %llu (got) != %llu (expected)";
+  //   size_t len      = std::snprintf(nullptr, 0, fmt, info->length, _length);
+  //   _status_msg     = std::string(len + 1, '\0');  // +1 for null terminator
+  //   std::snprintf(_status_msg.data(), _status_msg.size(), fmt, info->length, _length);
+  // }
 
   Request::callback(request, status);
 }

diff --git a/python/ucxx/_lib_async/tests/test_send_recv.py b/python/ucxx/_lib_async/tests/test_send_recv.py
@@ -120,6 +120,7 @@ async def test_send_recv_numba(size, dtype):
 
 
 @pytest.mark.asyncio
+@pytest.mark.skip(reason="See https://github.com/rapidsai/ucxx/issues/104")
 async def test_send_recv_error():
     async def say_hey_server(ep):
         await ep.send(bytearray(b"Hey"))