UIP 8: Address-linked attestations #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
reviewed
Dec 9, 2024
Comment on lines
+153
to
+155
| The message field MUST be a `google.protobuf.Any` rather than raw bytes. This allows: | ||
| 1. Custody backends to decode and understand specific message types they support | ||
| 2. Wallets to implement domain-specific user confirmation flows (e.g. "You are attesting that you control this address for purpose X") |
There was a problem hiding this comment.
this is a good idea, there should be a description of what the request is actually attesting (is it the byte encoding of the Any?)
redshiftzero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to https://forum.penumbra.zone/t/pre-uip-address-linked-attestations/111/1
This design is not urgent, just dropping here in case folks have thoughts