Make env route dynamic #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
force-pushed
the
force-dynamic
branch
from
57e4821 to
ccc386a
Compare
conorsch
force-pushed
the
force-dynamic
branch
from
70b1bc3 to
ccc386a
Compare
|
Nice! This change resolved the specific problem reported in #121, where testnet asset lookup was failing. Running this new code, I see in the browser console that the correct lookup is performed via GET:
which confirms that the server-side env var is now properly configuring the app behavior, as we wanted. Problems still remain in terms of overall app stability, but will file follow-up issues for those so they can be addressed appropriately. |
conorsch
approved these changes
Nov 4, 2024
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly closes #121
By default, the
api/envroute was being built statically at build time. It looks like Nextjs recognized that it depended on static variables (env vars) and thought it a good idea to pre-build the route's response #facepalm.Before:
After: