ui: display relevant accounts #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalDerei
commented
Dec 11, 2024
grod220
reviewed
Dec 11, 2024
| "@penumbra-zone/crypto-web": "^30.0.0", | ||
| "@penumbra-zone/getters": "^20.0.0", | ||
| "@penumbra-zone/perspective": "^40.0.0", | ||
| "@penumbra-zone/protobuf": "^6.3.0", | ||
| "@penumbra-zone/transport-dom": "^7.5.0", | ||
| "@penumbra-zone/types": "^26.3.0", | ||
| "@penumbra-zone/ui": "^13.4.2", | ||
| "@penumbra-zone/ui": "^13.5.0", |
There was a problem hiding this comment.
Looks like we have some density issues:
There was a problem hiding this comment.
density updates from the UI package bump are aggregately addressed in #204 cc @VanishMax
grod220
approved these changes
Dec 11, 2024
| @@ -23,7 +24,11 @@ export const SubaccountSelector = observer(() => { | |||
| <DropdownMenu> | |||
| <DropdownMenu.Trigger> | |||
| <Button> | |||
| <AddressViewComponent copyable={false} addressView={valueAddress} /> | |||
| {isLoading ? ( | |||
| <SpinnerIcon className='animate-spin' /> | |||
There was a problem hiding this comment.
Suggestion: When it loads, the main acccount state of the button is ~170px wide. Think we should make the button width in the loading state the same width so there is less screen jank as it transitions from loading to loaded.
There was a problem hiding this comment.
noting that a width of ~142px fits perfectly on screen reloads, but I adjusted it to 170px to match the button width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #155
useSubaccountsreact-query hook is tracked by mobx observer HOC, and queries account balances from the view service to display the relevant accounts.the
Address ViewV2 UI component (penumbra-zone/web#1941) was implemented towards realizing this.Screen.Recording.2024-12-11.at.9.14.48.AM.mov