Don't calculate in constructor #208
Open
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
commented
Dec 12, 2024
| @@ -57,7 +57,6 @@ class OrderFormStore { | |||
| makeAutoObservable(this); | |||
|
|
|||
| void this.calculateGasFee(); | |||
| void this.calculateExchangeRate(); | |||
There was a problem hiding this comment.
@JasonMHasperhoven can you validate this is ok? On load, there is no assetIds set so it is throwing. Upon the assetIds loading in the store, it re-renders and runs the calculations later anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cause of an error toast on load: