Skip to content

Commit

Permalink
fix: update dependencies in parameter-setup crate (#4930)
Browse files Browse the repository at this point in the history
## Describe your changes

The parameter-setup crate was broken due to outdated dependencies. The
options here are:
1. add this tool to the workspace
2. keep the dependencies updated instead of using workspace inheritance

Option 1 is more maintainable. Even though the parameters are fixed now
due to mainnet, folks may try to use this crate for debugging - the
scenario that motivated this commit.

To test: I followed the steps in
https://guide.penumbra.zone/dev/parameter_setup to ensure we could run
the parameter setup.

## Issue ticket number and link

This was discovered while debugging #4927

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > this is a dev only change
  • Loading branch information
redshiftzero authored Nov 18, 2024
1 parent b252061 commit 63d1d33
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 5 deletions.
17 changes: 17 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

resolver = "2"

exclude = ["tools/proto-compiler", "tools/parameter-setup"]
exclude = ["tools/proto-compiler"]

# Also remember to add to deployments/scripts/rust-docs
members = [
Expand Down Expand Up @@ -55,6 +55,7 @@ members = [
"crates/view",
"crates/wallet",
"tools/summonerd",
"tools/parameter-setup",
]

# Config for 'cargo dist'
Expand Down
8 changes: 4 additions & 4 deletions tools/parameter-setup/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ penumbra-shielded-pool = { path = "../../crates/core/component/shielded-pool/",
penumbra-stake = { path = "../../crates/core/component/stake/", features = [
"component",
] }
ark-groth16 = "0.4"
ark-serialize = "0.4"
decaf377 = { version = "0.5", features = ["r1cs"] }
rand_core = "0.6.4"
ark-groth16 = { workspace = true }
ark-serialize = { workspace = true }
decaf377 = { workspace = true, features = ["r1cs"] }
rand_core = { workspace = true }

0 comments on commit 63d1d33

Please sign in to comment.