build: set resolver=1 for workspace #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our cargo actions were emitting a warning:
warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
Updating the workspace's Cargo.toml to force use of resolver v1 for the
workspace. Setting v2 broke the "rust-docs" script, so hardcoding the
current behavior to eliminate warnings.
See related docs: https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html
conorsch
force-pushed
the
virtual-workspace-resolver-2
branch
from
c4766f2 to
e3bbe33
Compare
conorsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cargo actions were emitting a warning:
Updating the workspace's Cargo.toml to force use of resolver v1 for the workspace. Setting v2 broke the "rust-docs" script, so hardcoding the current behavior to eliminate warnings.
See related docs: https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html