Proof-Setup: Implement linking between phases, test integration with the rest of the codebase #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next step is testing this bit of code and actually fleshing out the API.
The test just needs to pass, otherwise should be what we need.
We lift the abstraction layer one level up, only requiring circuits to generate a version of themselves with dummy witnesses, and not the entire parameters.
Also adjusts the size to the rounded up power of 2, reflecting what actually happens.
These are still "backdoored", but now use the same code path as the eventual decentralized setup.
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
This was an artifact from an earlier organizational idea.
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
We want this in for 60: @redshiftzero is reviewing, aiming to merge by EOD. |
redshiftzero
approved these changes
Sep 8, 2023
| // I honestly don't know why this would fail. | ||
| // But if it does, it's not at runtime in a node. | ||
| cs.to_matrices() | ||
| .expect("can convert R1CS constraints into matrices") |
There was a problem hiding this comment.
I think this can only fail if you call to_matrices prior to constraint generation, but since you're calling it after constraint generation and then calling ConstraintSystemRef::finalize this should never happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2871.
This completes the internal setup ceremony code (sans some extra benchmarks we might want, and parallelizing the contribution and or verification).
This also changes our tool to generate proving and verifying keys to use the setup ceremony code to run a "ceremony" locally, involving 2 contributors, thus exercising this code path to generate the keys we use for proving and verifying, which should hopefully prevent any snafus from integrating the future output we expect to have.