Add test for and fix arbitrage swap execution output amount #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbuc
force-pushed
the
3790_arbitrage_fix
branch
from
419051f to
0a6c792
Compare
erwanor
approved these changes
Apr 29, 2024
zbuc
force-pushed
the
3790_arbitrage_fix
branch
from
f3f2cd3 to
67ecb83
Compare
zbuc
force-pushed
the
3790_arbitrage_fix
branch
from
67ecb83 to
af80b38
Compare
erwanor
added
state-breaking
erwanor
approved these changes
May 1, 2024
| new_key = ?EscapedByteSlice(&new_key), | ||
| ?old_key, | ||
| "updated liquidity index" | ||
| ); |
There was a problem hiding this comment.
ACK, read through the code and it look correct to me, we:
- Create a (K, V) stream
- Pull the aggregate amount from the key @
32 + 7..32 + 7 + 16 - Compute the complement, encode it as big endian
- Delete the old key
- Insert the new key
cratelyn
reviewed
May 1, 2024
Co-authored-by: Erwan Or <[email protected]> Signed-off-by: Chris Czub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This extends the existing arbitrage test to ensure that the created
SwapExecutionhas the expected trace and input/output values, as well as fixes the bug described in #3790 whereSwapExecutions were created with incorrectOutputvalues.Issue ticket number and link
#3790
Checklist before requesting a review
Additional Follow-up
This will require a migration to update the existing
SwapExecutionstructures. The migration should be as simple as adding theinputto theoutputfor each of them.